Use newer BigDecimal api to avoid extra String allocation
#28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winfriedgerlach
changed the title
Member
|
@winfriedgerlach Sounds good. One request: could you separate out basic clean up (cast removal, keyword order, no functional change) and then the main fix(es) (avoiding extra |
cowtowncoder
changed the title
BigDecimaal api to avoid extra String allocation
cowtowncoder
changed the title
BigDecimaal api to avoid extra String allocationBigDecimal api to avoid extra String allocation
winfriedgerlach
force-pushed
the
feature/use-newer-API-for-better-performance
branch
from
7deb765 to
c1915bf
Compare
Contributor
Author
@cowtowncoder sure, rebased on master and removed cleanup commit (which is now #29) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.