BGV Relin Bug Fixes #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stopherngutierrez/relin
…r reconsidered in the future
christopherngutierrez
requested review from
faberga,
kylanerace,
jobottle,
hamishun and
jlhcrawford
as code owners
jobottle
previously approved these changes
Sep 9, 2024
kylanerace
previously approved these changes
Sep 13, 2024
|
Two comments: I have some questions about the python constructs used in relin.py, particularly storing the "opts" or lists in a variable just to return them at the end of the code block. Since the code block already builds a list, it could be returned directly. Since you already stated the need for refactoring, and this PR seems to be passing the validation tests, why not use this as your base and refactor now? -Flavio |
faberga
reviewed
Sep 17, 2024
faberga
reviewed
Sep 17, 2024
Removed variable from opts from relin.
christopherngutierrez
dismissed stale reviews from kylanerace and jobottle
via
f12d252
kylanerace
approved these changes
Sep 17, 2024
faberga
approved these changes
Sep 18, 2024
christopherngutierrez
added a commit
that referenced
this pull request
Oct 21, 2024
This PR implements the an experimental fix for a few issues in the RELIN kernel. Namely, the RELIN kernel generated code that was segmented due issues with composing DigitalDecompExtend and Keymul together. This fix uses internal temporary variables output_tmp , which will be refactored out in a following PR. Further, the input polynomials parts are hardcoded to 3 and output parts to 2 since the code assumes those sizes (also to be refactored to be more generic in the future). Today the RELIN kernel only supports 16k polynomials due to a limitation of the NTT/INTT kernels. This limitation is being removed and the RELIN kernel will be updated accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR implements the an experimental fix for a few issues in the RELIN kernel. Namely, the RELIN kernel generated code that was segmented due issues with composing DigitalDecompExtend and Keymul together. This fix uses internal temporary variables output_tmp , which will be refactored out in a following PR. Further, the input polynomials parts are hardcoded to 3 and output parts to 2 since the code assumes those sizes (also to be refactored to be more generic in the future).
Today the RELIN kernel only supports 16k polynomials due to a limitation of the NTT/INTT kernels. This limitation is being removed and the RELIN kernel will be updated accordingly.
Types of changes
What types of changes does your code introduce to the HE Toolkit project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments