Skip to content

fix: Only set CustomRefreshControl if the user sets onRefresh prop #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Only set CustomRefreshControl if the user sets onRefresh prop #21

wants to merge 2 commits into from

Conversation

@indraneelpatil
Copy link

@indraneelpatil indraneelpatil commented Apr 8, 2025 •
edited
Loading

Hi! 👋

Thanks for making this component available!

I ran into the issue described here: #12 So I decided to attempt the solution proposed there:

Solution: Only set CustomRefreshControl if the user sets onRefresh prop

This solves my problem. How was this tested:

  1. I tested this on web version of my app
  2. Ensured other FlatLists dont break

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@indraneelpatil