Skip to content

fix: Only set CustomRefreshControl if the user sets onRefresh prop #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Only set CustomRefreshControl if the user sets onRefresh prop #21

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
752c98d
Only set custom refresh control if user sets onRefresh
Apr 8, 2025
fa0fdf7
formatting
Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,23 @@ export function patchFlatListProps(options = {}) {
function setCustomFlatListWeb(options) {
FlatList.defaultProps = {
...FlatList.defaultProps,
//eslint-disable-next-line react/display-name
renderScrollComponent: props => (
// eslint-disable-next-line react/display-name
renderScrollComponent: (props) => (
<ScrollView
{...props}
//eslint-disable-next-line react/prop-types
refreshControl={<CustomRefreshControl {...options} refreshing={props.refreshing} onRefresh={props.onRefresh} />}
// eslint-disable-next-line react/prop-types
refreshControl={
props.onRefresh
? (
<CustomRefreshControl
{...options}
refreshing={props.refreshing}
onRefresh={props.onRefresh}
/>
)
: props.refreshControl // fallback to existing refreshControl if any
}
/>
),
}
};
}