zynqmp_r5: use libmetal extension module #84
+168
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnopo
reviewed
Sep 29, 2025
| if (FIND_FREERTOS) | ||
| collect(PROJECT_LIB_DEPS freertos) | ||
| endif(FIND_FREERTOS) | ||
| collect(PROJECT_LIB_DEPS "libfreertos.a") |
There was a problem hiding this comment.
seems strange that you have to change the Freertos integration method. the original declaration seems to me more generic
There was a problem hiding this comment.
@arnopo
Actually you are right. collect(PROJECT_LIB_DEPS <text>) ends up as linker flags -l<text> I should keep it as before. Other places as well. I will fix it.
xlnx bsp implementation of some libmetal interfaces was moved from libmetal library repo to vendor repo. Application should use this new vendor specific library via libmetal API for platform specific configuration. For example, GIC configuration on cortex-R cores on xlnx platforms. Do required changes in legacy apps to use this new extension module for xlnx cortex-R port. Signed-off-by: Tanmay Shah <[email protected]>
Add cmake file for freertos. This assigns project system variable. Current build on freertos fails due to undefined API used. Also, suspend.c file declares extern variable that is not found during compile time. Solve this by getting current task handle in suspend resume APIs instead passing an argument to the function. Signed-off-by: Tanmay Shah <[email protected]>
PROJECT_SYSTEM variable was added based on CMAKE_SYSTEM_NAME, however cmake doesn't support some RTOS names such as FreeRTOS. So, PROJECT_SYSTEM value can be different than CMAKE_SYSTEM_NAME. Toolchain file includes these cmake files. So PROJECT_SYSTEM variable assignment from options.cmake can be removed safely. Instead assign value to PROJECT_SYSTEM variable in relative OS cmake file. Signed-off-by: Tanmay Shah <[email protected]>
tnmysh
force-pushed
the
xlnx_use_libmetal_extension_module
branch
from
993a302 to
ffc2cc6
Compare
arnopo
approved these changes
Oct 6, 2025
| #ifndef RPMSG_NO_IPI | ||
| .irq_num = 1, | ||
| #ifdef FREERTOS_BSP | ||
| .irq_info = (void *)(IPI_IRQ_VECT_ID - 32), |
There was a problem hiding this comment.
nitpicking : The value 32 seems a magic number here. I could be better to use a define or a config linked to FreeRTOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xlnx BSP was moved out of libmetal to new library module maintained in downstream repo: libmetal_xlnx_extension.a
Modify zynqmp_r5 platform to use interrupt controller defined in this new library module.
In the process fix freertos compilation on zynqmp_r5 platform as well.