-
Notifications
You must be signed in to change notification settings - Fork 6
feat(logging): make elastic stack optional #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
w-le
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks lgtm,
non-urgently, can you also add a convenience improvement where the elastic stack can be installed when a COMMAND LINE PARAM is specified, not just a change in.env? You should be able to copy the method used in ./install:33-37
|
Closes #7 |
compose-files/elastic-stack.yml
Outdated
| placeos: | ||
| volumes: | ||
| - /var/run/docker.sock:/var/run/docker.sock | ||
| command: gelf://${LOGSTASH_HOST}:${LOGSTASH_PORT} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if the gelf version supports this, but if this can be filtered to only PlaceOS containers it will protected against trawling all logs.
When ENABLE_ELASTIC_STACK == true the containers will be added to docker-compose.yml
…k if disabled in .env
This saves extra allowlist entries
|
Made a bunch of changes. Fixed
Added
Changed
Removed
|
|
Since we're now using the Open Distro for Elasticsearch containers, this issue is not blocked #69 |
|
Also looks like |
|
Open distro for elasticsearch is SUPER heavy. To reduce the size of the images, we can use the open distro plugins on top of blacktop’s alpine kibana/elastic container. |
Also removes some intermediary patch versions < `1.2109.x`
Remove `sentry` from the set of vendored services. Support for `SENTRY_DSN` remains on service and interfaces.
|
What's left of this PR's move to add opendistro for elasticsearch has been shifted to a separate PR, #100 |
The issue of logspout using large amounts of cpu was caused by the source container restarting which is now resolved, 8f1ef39
Still, as these containers are not usually needed they have been removed from the default docker-compose.yml to be added in by
installwhenENABLE_ELASTIC_STACK=truein.env