Skip to content

feat: performance / semaphore tracking, worker log suppression, log improvement #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: performance / semaphore tracking, worker log suppression, log improvement #1045

wants to merge 4 commits into from

Conversation

dodamih
Copy link
Collaborator

@dodamih dodamih commented Sep 25, 2025

No description provided.

@dodamih dodamih force-pushed the dodam/idle_timeout branch 3 times, most recently from 4256020 to 7d58c73 Compare September 25, 2025 07:38
@dodamih dodamih changed the title [DO NOT MERGE] feat: performance / semaphore tracking, worker log suppression feat: performance / semaphore tracking, worker log suppression, log improvement Sep 25, 2025
@dodamih dodamih linked an issue Sep 25, 2025 that may be closed by this pull request
Heavy performance degradation with large subchunkable L1 chunks #892
Open
@dodamih dodamih force-pushed the dodam/idle_timeout branch 2 times, most recently from 87a4151 to 0d5493b Compare September 25, 2025 08:04
trivoldus28
trivoldus28 reviewed Sep 25, 2025
View reviewed changes
@dodamih dodamih force-pushed the dodam/idle_timeout branch 2 times, most recently from 4a708a9 to 541bae4 Compare September 25, 2025 09:52
@codecov Codecov
Copy link

codecov bot commented Sep 25, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 86.98347% with 63 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.24%. Comparing base (6622ca9) to head (c431fe7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
zetta_utils/common/resource_monitor.py 77.47% 50 Missing ⚠️
zetta_utils/mazepa/semaphores.py 94.86% 13 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##              main    #1045      +/-   ##
===========================================
- Coverage   100.00%   99.24%   -0.76%     
===========================================
  Files          175      176       +1     
  Lines         8036     8508     +472     
===========================================
+ Hits          8036     8444     +408     
- Misses           0       64      +64

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dodamih dodamih force-pushed the dodam/idle_timeout branch 2 times, most recently from baea0a0 to 06a0eb4 Compare September 25, 2025 10:26
@dodamih
Copy link
Collaborator Author

dodamih commented Sep 25, 2025

Still working on test coverage... a little painful to make shm exceptions though.

nkemnitz
nkemnitz reviewed Sep 26, 2025
View reviewed changes
nkemnitz
nkemnitz reviewed Sep 26, 2025
View reviewed changes
@dodamih dodamih force-pushed the dodam/idle_timeout branch from 06a0eb4 to d0ada41 Compare October 3, 2025 05:34
@dodamih dodamih force-pushed the dodam/idle_timeout branch from d0ada41 to c431fe7 Compare October 3, 2025 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivoldus28 trivoldus28 trivoldus28 left review comments

@nkemnitz nkemnitz nkemnitz left review comments

@supersergiy supersergiy Awaiting requested review from supersergiy

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Heavy performance degradation with large subchunkable L1 chunks
3 participants
@dodamih @trivoldus28 @nkemnitz