Fix several supervisor issues and bugs #1958
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a missing edge case in loop_terminate/2 that could lead to loop_wait_termination/1 getting stuck in an endless receive, preventing shutdown, if a later child crashes before loop_terminate/2 has itterated through the children to the now dead one. Fixes a typo in the init funtion error return where the atom `mod` was returned rather than the modules name (`Mod`). Fixes a typo in child record `type`, adds missing parenthesis on the `child_type/0` type. Signed-off-by: Winford <[email protected]>
Fixes some tests to catch the messages from child ping_pong_servers so they will not be received by later tests. Changes the supervisor started in test_count_children to use a generic supervisor without a child, rather than using the modules start_link which always starts a child ping_pong_server that sends messages back to the test environment. Fixes the test_ping_ping final `recieve` to match on a new `Pid4` (which would indicate a restart) rather than `Pid3` that the monitor just caught the 'DOWN' message for. Signed-off-by: Winford <[email protected]>
Adds support for handling restarts for the `one_for_all` strategy that was documented, but lacked implimentation. Closes atomvm#1855 Signed-off-by: Winford <[email protected]>
Adds support for honoring intensity and period supervisor options, allowing the prevention of endless crash and restarts by misbehaving children. Adds a test to ensure the settings work as expected on AtomVM and match OTP. Closes atomvm#1915 Signed-off-by: Winford <[email protected]>
petermm
reviewed
Nov 4, 2025
| {error, no_supervisor2} | ||
| end, | ||
| ok = | ||
| case is_pid(ChildPid) of |
There was a problem hiding this comment.
believe you want ChildPid2 here
There was a problem hiding this comment.
Yes I do! Thank you. I reworked this function a bit too, I decided it was a waist of CI time to wait 2000 ms for a child message if the supervisor failed to start 🤦 . I moved the check for a supervisor pid sooner and a fixed the variable name.
Fixes a function clause exception that would crash the supervisor if a child fails to restart by matching the same behavior as OTP, and continue to try restarting the child until success, or maximum `intensity` is reached within the allowed `period`. Closed atomvm#1957 Signed-off-by: Winford <[email protected]>
UncleGrumpy
force-pushed
the
supervisor-one_for_all-main
branch
from
e0f3afd to
7b2435d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix several open supervisor issues, as well as a few small bugs discovered in the supervisor and test_supervisor.erl.
one_for_allrestart strategy that is documented in the module.intensityandperiodoptions.test_supervisor:/test/0.Closes #1855
Closes #1915
Closed #1957
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later