DOCS: Updated docker instructions, removed obsolete variables #2217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2195 Signed-off-by: Sebastian Waldbauer <[email protected]>
sebix
requested changes
Jul 15, 2022
| -e INTELMQ_SOURCE_PIPELINE_HOST: redis \ | ||
| -e INTELMQ_DESTINATION_PIPELINE_HOST: redis \ | ||
| -e INTELMQ_REDIS_CACHE_HOST: redis \ | ||
| sudo docker run -e INTELMQ_PIPELINE_HOST: redis \ |
There was a problem hiding this comment.
The environment variable INTELMQ_PIPELINE_HOST is only used in the tests, but not in the normal pipeline/bot code. Should be INTELMQ_SOURCE_PIPELINE_HOST and INTELMQ_DESTINATION_PIPELINE host IMO.
There was a problem hiding this comment.
To clarify what I meant: Setting INTELMQ_PIPELINE_HOST does not set the pipeline host to redis for the bots at runtime and is thus ineffective.
sebix
added
bug
|
@kamil-certat maybe you could help here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2195