Skip to content

DOCS: Updated docker instructions, removed obsolete variables #2217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

DOCS: Updated docker instructions, removed obsolete variables #2217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions docs/user/installation.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,14 +187,7 @@ In order to work with your current infrastructure, you need to specify some envi
--name nginx \
certat/intelmq-nginx:latest

sudo docker run -e INTELMQ_IS_DOCKER="true" \
-e INTELMQ_SOURCE_PIPELINE_BROKER: "redis" \
-e INTELMQ_PIPELINE_BROKER: "redis" \
-e INTELMQ_DESTIONATION_PIPELINE_BROKER: "redis" \
-e INTELMQ_PIPELINE_HOST: redis \
-e INTELMQ_SOURCE_PIPELINE_HOST: redis \
-e INTELMQ_DESTINATION_PIPELINE_HOST: redis \
-e INTELMQ_REDIS_CACHE_HOST: redis \
sudo docker run -e INTELMQ_PIPELINE_HOST: redis \
Copy link
Member

@sebix sebix Jul 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The environment variable INTELMQ_PIPELINE_HOST is only used in the tests, but not in the normal pipeline/bot code. Should be INTELMQ_SOURCE_PIPELINE_HOST and INTELMQ_DESTINATION_PIPELINE host IMO.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify what I meant: Setting INTELMQ_PIPELINE_HOST does not set the pipeline host to redis for the bots at runtime and is thus ineffective.

-v $(pwd)/example_config/intelmq/etc/:/etc/intelmq/etc/ \
-v $(pwd)/example_config/intelmq-api/config.json:/etc/intelmq/api-config.json \
-v $(pwd)/intelmq_logs:/etc/intelmq/var/log \
Expand Down