update redirects #6
Draft
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
reviewed
Oct 1, 2025
| } else if (path.startsWith("/esp-hal/esp-wifi")) { | ||
| window.location.href = "https://docs.espressif.com/projects/rust/esp-wifi/latest/"; | ||
| window.location.href = "https://docs.espressif.com/projects/rust/esp-radio/latest/"; | ||
| } else if (path.startsWith("/esp-hal/esp-hal-embassy") || path.startsWith("/projects/rust/esp-hal-embassy")) { |
There was a problem hiding this comment.
I don't think there are any links out there matching path.startsWith("/projects/rust/esp-hal-embassy") 🤔
There was a problem hiding this comment.
https://docs.espressif.com/projects/rust/esp-hal-embassy/0.9.0/index.html will 404 once we remove the package (well, I guess it won't, but we might remove those files at some point in the future), so I added it here.
There was a problem hiding this comment.
ah yes - but we only get to this 404 handler via https://esp-rs.github.io/ - I think it's something for esp-rs/esp-hal#3388
There was a problem hiding this comment.
Oh yeah, of course 🤦♂️. I'll drop a comment in the PR for esp-rs/esp-hal#3388 and let's see if we can add it there.
bjoernQ
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drafting as we need to do the releases first