Skip to content

update redirects #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

update redirects #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion 404.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ <h1>Page Moved</h1>
if (path.startsWith("/esp-hal/esp-hal")) {
window.location.href = "https://docs.espressif.com/projects/rust/esp-hal/latest/";
} else if (path.startsWith("/esp-hal/esp-wifi")) {
window.location.href = "https://docs.espressif.com/projects/rust/esp-wifi/latest/";
window.location.href = "https://docs.espressif.com/projects/rust/esp-radio/latest/";
} else if (path.startsWith("/esp-hal/esp-hal-embassy") || path.startsWith("/projects/rust/esp-hal-embassy")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there are any links out there matching path.startsWith("/projects/rust/esp-hal-embassy") 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.espressif.com/projects/rust/esp-hal-embassy/0.9.0/index.html will 404 once we remove the package (well, I guess it won't, but we might remove those files at some point in the future), so I added it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes - but we only get to this 404 handler via https://esp-rs.github.io/ - I think it's something for esp-rs/esp-hal#3388

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, of course 🤦‍♂️. I'll drop a comment in the PR for esp-rs/esp-hal#3388 and let's see if we can add it there.

window.location.href = "https://docs.espressif.com/projects/rust/esp-rtos/latest/";
} else if (path.startsWith("/book")) {
const suffix = path.substring("/book/".length);
window.location.href = "http://docs.espressif.com/projects/rust/book/" + suffix;
Expand Down