-
Notifications
You must be signed in to change notification settings - Fork 332
sbpf: elf loader rewrite #6575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
sbpf: elf loader rewrite #6575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
04f1e01
to
e04b487
Compare
a404393
to
37c5e2e
Compare
0x0ece
approved these changes
Oct 3, 2025
0x0ece
requested changes
Oct 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main thing I'd say is to squash all commits
304dd9a
to
ea535b9
Compare
5ffc837
to
b750840
Compare
0x0ece
previously approved these changes
Oct 6, 2025
fadd6c4
to
669a5cd
Compare
0x0ece
previously approved these changes
Oct 6, 2025
reviewing, please don't merge yet |
ripatel-fd
requested changes
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed about half of it. Will revisit the relocation code
35b39a3
to
69cdb59
Compare
5ddfde2
to
de438bb
Compare
ripatel-fd
previously approved these changes
Oct 7, 2025
cmoyes-jump
previously approved these changes
Oct 7, 2025
cmoyes-jump
reviewed
Oct 7, 2025
c4b954a
de438bb
to
c4b954a
Compare
c4b954a
to
71dbb68
Compare
cmoyes-jump
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.