Skip to content

Conversation

mjain-jump
Copy link
Contributor

No description provided.

@mjain-jump mjain-jump force-pushed the mjain/elf-loader-rewritre branch 2 times, most recently from 04f1e01 to e04b487 Compare October 2, 2025 17:00
@0x0ece 0x0ece marked this pull request as ready for review October 3, 2025 14:58
@mjain-jump mjain-jump force-pushed the mjain/elf-loader-rewritre branch from a404393 to 37c5e2e Compare October 3, 2025 15:25
Copy link
Contributor

@0x0ece 0x0ece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main thing I'd say is to squash all commits

@mjain-jump mjain-jump force-pushed the mjain/elf-loader-rewritre branch 4 times, most recently from 304dd9a to ea535b9 Compare October 6, 2025 15:07
@mjain-jump mjain-jump force-pushed the mjain/elf-loader-rewritre branch 4 times, most recently from 5ffc837 to b750840 Compare October 6, 2025 15:22
@mjain-jump mjain-jump changed the title [WIP] sbpf: elf loader rewrite sbpf: elf loader rewrite Oct 6, 2025
0x0ece
0x0ece previously approved these changes Oct 6, 2025
@mjain-jump mjain-jump force-pushed the mjain/elf-loader-rewritre branch 2 times, most recently from fadd6c4 to 669a5cd Compare October 6, 2025 18:07
0x0ece
0x0ece previously approved these changes Oct 6, 2025
@ripatel-fd
Copy link
Contributor

reviewing, please don't merge yet

Copy link
Contributor

@ripatel-fd ripatel-fd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed about half of it. Will revisit the relocation code

@mjain-jump mjain-jump force-pushed the mjain/elf-loader-rewritre branch 2 times, most recently from 35b39a3 to 69cdb59 Compare October 6, 2025 19:39
ripatel-fd
ripatel-fd previously approved these changes Oct 7, 2025
cmoyes-jump
cmoyes-jump previously approved these changes Oct 7, 2025
@mjain-jump mjain-jump dismissed stale reviews from cmoyes-jump and ripatel-fd via c4b954a October 7, 2025 14:05
@mjain-jump mjain-jump force-pushed the mjain/elf-loader-rewritre branch from de438bb to c4b954a Compare October 7, 2025 14:05
@mjain-jump mjain-jump force-pushed the mjain/elf-loader-rewritre branch from c4b954a to 71dbb68 Compare October 7, 2025 14:10
@mjain-jump mjain-jump enabled auto-merge October 7, 2025 14:13
@mjain-jump mjain-jump added this pull request to the merge queue Oct 7, 2025
Merged via the queue into main with commit da36933 Oct 7, 2025
11 checks passed
@mjain-jump mjain-jump deleted the mjain/elf-loader-rewritre branch October 7, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants