tests: unskip and fix offline mode test using HF_HUB_OFFLINE + hermetic cache warmup #41312
+5
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The offline test was skipped and brittle due to reliance on TRANSFORMERS_OFFLINE and pre-warmed caches. Standardize on HF_HUB_OFFLINE and make the test self-contained and deterministic.
Fixes #41311
Changes:
test_offline_mode
.HF_HUB_OFFLINE=1
and a socket.socket monkey-patch to fail on any network access; load everything from local cache.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
tests/utils/test_offline.py::OfflineTests::test_offline_mode
to be hermetic (two-step subprocess: cache warmup online, then offline withHF_HUB_OFFLINE=1
and socket mock).How to validate
Run:
pytest -q tests/utils/test_offline.py::OfflineTests::test_offline_mode
@Cyrilvallez
@Rocketknight1
@ydshieh