Skip to content

tests: unskip and fix offline mode test using HF_HUB_OFFLINE + hermetic cache warmup #41312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+5 −12
Open

tests: unskip and fix offline mode test using HF_HUB_OFFLINE + hermetic cache warmup #41312

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
626e21b
rewritten test_offline_mode
arvinder004 Oct 3, 2025
c190625
removed unused imports
arvinder004 Oct 3, 2025
f3503a2
removed unrelated changes
arvinder004 Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions tests/utils/test_offline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,13 @@

import subprocess
import sys
import unittest

from transformers import BertConfig, BertModel, BertTokenizer, pipeline
from transformers.testing_utils import TestCasePlus, require_torch


class OfflineTests(TestCasePlus):
@require_torch
@unittest.skip("This test is failing on main") # TODO matt/ydshieh, this test needs to be fixed
def test_offline_mode(self):
# this test is a bit tricky since TRANSFORMERS_OFFLINE can only be changed before
# `transformers` is loaded, and it's too late for inside pytest - so we are changing it
Expand All @@ -49,17 +47,12 @@ def test_offline_mode(self):
def offline_socket(*args, **kwargs): raise RuntimeError("Offline mode is enabled, we shouldn't access internet")
socket.socket = offline_socket
"""
# First subprocess run to warm the cache (online, no mocking)
stdout, _ = self._execute_with_env(load, run)
self.assertIn("success", stdout)

# Force fetching the files so that we can use the cache
mname = "hf-internal-testing/tiny-random-bert"
BertConfig.from_pretrained(mname)
BertModel.from_pretrained(mname)
BertTokenizer.from_pretrained(mname)
pipeline(task="fill-mask", model=mname)

# baseline - just load from_pretrained with normal network
# should succeed as TRANSFORMERS_OFFLINE=1 tells it to use local files
stdout, _ = self._execute_with_env(load, run, mock, TRANSFORMERS_OFFLINE="1")
# Second subprocess run in offline mode: ensure no network and use local cache only
stdout, _ = self._execute_with_env(load, mock, run, HF_HUB_OFFLINE="1")
self.assertIn("success", stdout)

@require_torch
Expand Down