Skip to content

fix: more correct return type for getSigningClient #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2025
+1 −2
Merged

fix: more correct return type for getSigningClient #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/core/src/wallet-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { AssetList, Chain } from '@chain-registry/types';
import { getWalletByType } from '@interchain-kit/core';
import { AminoSigner, CosmosSignerConfig, createCosmosQueryClient, DirectSigner, OfflineSigner } from '@interchainjs/cosmos';
import { ISigningClient } from '@interchainjs/cosmos/types/signing-client';
import { HttpEndpoint } from '@interchainjs/types';
import Bowser from 'bowser';
import { getSigner } from 'interchainjs';
Expand Down Expand Up @@ -247,7 +246,7 @@ export class WalletManager {
return cosmosWallet.getOfflineSigner(chain.chainId, preferredSignType);
}

async getSigningClient(walletName: string, chainName: ChainName): Promise<ISigningClient> {
async getSigningClient(walletName: string, chainName: ChainName): Promise<DirectSigner | AminoSigner> {
try {
const chain = this.getChainByName(chainName);
const rpcEndpoint = await this.getRpcEndpoint(walletName, chainName);
Expand Down
Loading