Skip to content

fix: don't accept a password longer than 72 bytes #6848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

fix: don't accept a password longer than 72 bytes #6848

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ee4104
fix: don't accept a password longer than 72 bytes
btasker Jan 3, 2024
6d15bf6
fix: add missing bracket (had fixed earlier but not saved)
btasker Jan 3, 2024
0b39f83
chore: refactor to fix tests
btasker Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/onboarding/containers/LoginPageContents.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,11 +174,15 @@ class LoginPageContents extends PureComponent<Props> {
const {email, password} = this.state

const emailError = email === '' ? 'Email is required' : ''
const pwlen = new Blob([password]).size

const passwordError = password === '' ? 'Password is required' : ''
const passwordLenError = pwlen > 72 ? 'Password is longer than 72 bytes' : ''

const errors: ErrorObject = {
emailError,
passwordError,
passwordLenError,
}

const isValid = Object.values(errors).every(error => error === '')
Expand Down