Remove unnecessary masks #5384
Merged
Remove unnecessary masks #5384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ettore Tiotto <[email protected]>
Signed-off-by: Ettore Tiotto <[email protected]>
whitneywhtsang
approved these changes
Oct 31, 2025
third_party/intel/lib/Dialect/Triton/Transforms/RemoveMasks.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/Dialect/Triton/Transforms/RemoveMasks.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Ettore Tiotto <[email protected]>
…ltiple results Signed-off-by: Ettore Tiotto <[email protected]>
Contributor
Author
|
Run micro-benchmarks on b580 and this PR did not regress any of the benchmarks |
Contributor
Author
|
No inductor or accuracy PyTorch tests failure detected. This is good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the
RemoveMaskpass in order to consider mask on load and select operations that evaluate to true (or false) in the entire loop iteration space. This masked loads to be transformed into unmasked ones, and the mask condition may become dead if not used by other operations (therefore it may contribute to reduction of arithmetic complexity).