-
Notifications
You must be signed in to change notification settings - Fork 1
Move Metadata code from CTL #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Once tested, we're good to merge. If you could also submit a quick PR to CTL removing the code you've copied here, that'd be great also :D
e5ef9d1
to
f6b1831
Compare
f6b1831
to
3bc3a83
Compare
@samuelWilliams99 Using the changes from here and also my change described here I was able to test this out; listing NFTs seems to be working, but I get For this repository, this is the commit I used for testing (I merged my changes with that commit). Maybe I should change the base branch to aleksandr/fd-to-nix-develop or push the merge commit to this branch? PS I messed up some commits and did some force pushing to get things back to the way they were, no changes have been made, but I'm not sure how to get CI to run again. |
@samuelWilliams99 In CTL there are some tests for the seabug code, should I work on moving those over to this repository? This project doesn't seem to have testing set up yet and I'm not entirely sure how it should be done, but I can try to copy the setup from the CTL repo |
Agreed, let's try move over the minimal setup needed to run said tests |
Regarding buy - known issue, and regarding tests - you can push an empty commit if you'd like |
$ scriptHashFromBytes | ||
$ hexToRawBytesUnsafe | ||
"00000000000000000000000000000000000000000000000000000000" | ||
, mintPolicy: mempty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#13
We'll address this later
Addresses #9
develop
branch of CTL (commit6fca5ee2ff27f81762689c7da0d307e1afe7bbd3
)