Skip to content

Conversation

rynoV
Copy link
Contributor

@rynoV rynoV commented Jun 27, 2022

Addresses #9

  • Used develop branch of CTL (commit 6fca5ee2ff27f81762689c7da0d307e1afe7bbd3)
  • Copied Metadata/Seabug.purs from CTL to Seabug/Metadata/Types.purs in this repo
  • Copied Metadata/Seabug/Share.purs from CTL to Seabug/Metadata/Share.purs
  • Updated the imports which were pointing to those modules in CTL to point to the new modules within this repo

@samuelWilliams99 samuelWilliams99 added the enhancement New feature or request label Jun 27, 2022
@samuelWilliams99 samuelWilliams99 changed the base branch from master to neil/typescript-api June 27, 2022 16:21
Copy link
Contributor

@samuelWilliams99 samuelWilliams99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Once tested, we're good to merge. If you could also submit a quick PR to CTL removing the code you've copied here, that'd be great also :D

@rynoV rynoV force-pushed the calum/move-metadata-code branch from e5ef9d1 to f6b1831 Compare June 28, 2022 16:44
@rynoV rynoV force-pushed the calum/move-metadata-code branch from f6b1831 to 3bc3a83 Compare June 28, 2022 16:58
@rynoV
Copy link
Contributor

rynoV commented Jun 28, 2022

@samuelWilliams99 Using the changes from here and also my change described here I was able to test this out; listing NFTs seems to be working, but I get Error: marketplaceBuy: NFT not found on marketplace when I try to buy an NFT, I'm not sure if this is expected right now.

For this repository, this is the commit I used for testing (I merged my changes with that commit). Maybe I should change the base branch to aleksandr/fd-to-nix-develop or push the merge commit to this branch?

PS I messed up some commits and did some force pushing to get things back to the way they were, no changes have been made, but I'm not sure how to get CI to run again.

@rynoV rynoV requested a review from samuelWilliams99 June 28, 2022 17:08
@rynoV
Copy link
Contributor

rynoV commented Jun 28, 2022

If you could also submit a quick PR to CTL removing the code you've copied here

@samuelWilliams99 In CTL there are some tests for the seabug code, should I work on moving those over to this repository? This project doesn't seem to have testing set up yet and I'm not entirely sure how it should be done, but I can try to copy the setup from the CTL repo

@samuelWilliams99
Copy link
Contributor Author

samuelWilliams99 commented Jun 28, 2022

Agreed, let's try move over the minimal setup needed to run said tests

@samuelWilliams99
Copy link
Contributor Author

Regarding buy - known issue, and regarding tests - you can push an empty commit if you'd like

@rynoV rynoV mentioned this pull request Jun 29, 2022
7 tasks
@rynoV rynoV linked an issue Jul 4, 2022 that may be closed by this pull request
$ scriptHashFromBytes
$ hexToRawBytesUnsafe
"00000000000000000000000000000000000000000000000000000000"
, mintPolicy: mempty
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#13
We'll address this later

@rynoV rynoV merged commit 0dcae77 into neil/typescript-api Jul 6, 2022
@rynoV rynoV deleted the calum/move-metadata-code branch July 6, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move Metadata code from CTL

2 participants