Flake reprise

[aciceri]

I started working on #12 by @Synthetica9 with the goal of nixify the frontend too.

[Synthetica9]

What formatter do you use btw? As far as I'm aware we use nixpkgs-fmt for most projects

[aciceri]

What formatter do you use btw? As far as I'm aware we use nixpkgs-fmt for most projects

Oops, I enabled Alejandra to test it (seems really well done) and I think I forgot it enabled when writing this, I'll use nixpkgs-fmt next time.

[Synthetica9]

This is ready for merge IMO, but I didn't want to merge it myself

[samuelWilliams99]

Looks like seabug-contracts is still a submodule? (added recently in Calum's pr) (unless my UI is being weird)

[samuelWilliams99]

@rynoV Can you verify this is working as expected?

[rynoV]

Biggest issue right now is buildFrontend2.sh won't work and needs to be ported into nix

[rynoV]

Not sure if this is expected, but when I ran nix build --recreate-lock-file there were a lot of changes to this file. Is it out of date?

[aciceri]

No idea, there are several new inputs, maybe this is the reason?

[rynoV]

I can't spend any more time on this, but to summarize the changes I planned:

Dev environment

Currently there is no easy development experience. To fix this:

1. Use dev shell provided by dream2nix (.#d2nFlakeOutputs.devShells.x86_64-linux.default in this pr ) which is supposed to setup node_modules for us
   • I was running into an issue where the node_modules did not have all the modules, for example craco could not find webpack and webpack was not in node_modules
   • Also the node_modules created by dream2nix was a symlink instead of an actual folder (which I expected from this line, so I'm not sure what I'm missing there
2. Add seabug-contracts as a dependency in package.json for nft-marketplace, e.g. "seabug-contracts": "github:mlabs-haskell/seabug-contracts"
3. During development, remove node_modules/seabug-contracts and symlink the local clone of seabug-contracts
4. Do the rest of the stuff buildFrontend2.sh does

Prod build

I haven't checked that this works, and I'm also not exactly sure what our production build process is

[aciceri]

I was running into an issue where the node_modules did not have all the modules, for example craco could not find webpack and webpack was not in node_modules

Just a guess (probably wrong): maybe this is not dev dependency?

Moreover you could automatize the hacky symlinking overriding/adding a shellHook to the development shell to have it executed automatically and transparently.

Just another (probably pointless) idea: if we weren't using Nix I would say that since we are using docker-compose the best option would be to create another set of Docker images expressly for development that would mount the host local folders with the sources to the containers volumes. Is this something doable with arion too maybe?

[rynoV]

Just a guess (probably wrong): maybe this is not dev dependency?

craco isn't a dev dependency (maybe it should be). This was another weird thing I saw: the dream2nix noDev setting didn't seem to be respected; we set that to false, but dev dependencies weren't included in node_modules. If I manually copied them over to dependencies, they were included in node_modules.

Moreover you could automatize the hacky symlinking overriding/adding a shellHook to the development shell to have it executed automatically and transparently.

The hacky stuff was basically what dream2nix's dev shell is supposed to do already (I wasn't aware of that feature until you pointed it out), which is why I suggested we try to use that, but it's behaving strangely as described above.

Just another (probably pointless) idea: if we weren't using Nix I would say that since we are using docker-compose the best option would be to create another set of Docker images expressly for development that would mount the host local folders with the sources to the containers volumes. Is this something doable with arion too maybe?

I don't know how feasible that would be, and I'm also not sure how much time we want to spend on this, need to talk to @samuelWilliams99

[rynoV]

Plutonomicon/cardano-transaction-lib#956 might be useful

[aciceri]

This is mainly done now, I only have to rewrite current docs that now are obsolete.