Skip to content

Conversation

rynoV
Copy link
Contributor

@rynoV rynoV commented Dec 9, 2022

@aciceri
Copy link
Member

aciceri commented Dec 10, 2022

Hey @rynoV, I've applied and deployed Seabug with your new fix and it seems to work, great job!

By the way we're using now a completely different "deployment infrastructure", see #19
So this PR isn't good, I've already upgraded that branch locally to use your fix (I've just needed to run nix flake lock --upgrade-input nft-marketplace (and before I had to run nix flake lock --upgrade-input seabug-contracts in that repo) to upgrade the lockfile) but I still have to push my change since I would like that PRs are merged starting from leaves of dependency tree, this way I could use master/main as inputs for our flakes.

@aciceri aciceri closed this Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants