Updates to fix buy button showing for nft owner, and fix CIP25 metadata for blockfrost #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove connectWallet, replace with getWalletPkh, update getWalletBalance to return lovelace
|
I've pushed here changes needed by mlabs-haskell/nft-marketplace#231 without creating a new PR, this should all we need in this repository for Seabug deployment. |
samuelWilliams99
approved these changes
Nov 7, 2022
- Updates to a CTL revision which encodes the CIP25 metadata keys as strings instead of bytes, for compatibility with Blockfrost - Updates the Blockfrost response parsing for the new `onchain_metadata` format
rynoV
changed the title
samuelWilliams99
approved these changes
Dec 12, 2022
|
@samuelWilliams99 @rynoV so can we merge this? |
|
I believe so, but lets prehaps wait on Calum here |
|
@aciceri let's hold off for now, I may need to update the CTL revision again as changes were requested on my CTL PR. I'll let you know once my PR is merged, then we can merge this. For now though this version should work to fix the deployment. |
…racts into calum/fixing-buy-button
|
Hey @aciceri, we should be good to merge whenever. I also pushed another commit to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove connectWallet, replace with getWalletPkh, update getWalletBalance to return lovelace.
These changes are for mlabs-haskell/nft-marketplace#230
Also includes changes described here: mlabs-haskell/seabug#41
Also includes a fix to handle Blockfrost's recent change in handling CIP25 metadata, see: