Skip to content

Updates #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 7, 2022
Merged

Updates #41

merged 4 commits into from
Nov 7, 2022

Conversation

rynoV
Copy link
Contributor

@rynoV rynoV commented Nov 5, 2022 •
edited
Loading

  • Switch to updated preview network
  • Don't require a wallet unnecessarily (when fetching nft info)
  • Improve error messages to show that Nami is required
  • Avoid multiple wallet access permission popups on item page
    • The item page was running multiple contracts concurrently to get the wallet balance and pub key, and when the wallet permission had not already been granted, this resulted in two popups asking for permission.

PRs

TODO

  • Test out all features manually
  • Recreate test report
  • Check that these changes work in deployment

rynoV added 2 commits November 4, 2022 20:45
@rynoV
Switch cardano node to 1.35.4-rc1
347391d
@rynoV
Update frontend
d0dafd3 
- Don't require a wallet unnecessarily
- Improve error messages
- Avoid multiple wallet access permission popups on item page
@rynoV rynoV added the enhancement New feature or request label Nov 5, 2022
This was referenced Nov 5, 2022
Open
Merged
@rynoV rynoV merged commit c557189 into main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@samuelWilliams99 samuelWilliams99 samuelWilliams99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rynoV @samuelWilliams99