Skip to content

Use Empty rather than Any for message processing #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2023
Merged

Use Empty rather than Any for message processing #62

merged 1 commit into from
Feb 12, 2023

Conversation

adamthesax
Copy link
Contributor

This fixes #61. This is also based off of #57

@snyh snyh mentioned this pull request Jun 14, 2022
Closed
@fuhrmannb fuhrmannb mentioned this pull request Jun 19, 2022
Closed
wenfengwang added a commit to vanus-labs/grpc-proxy that referenced this pull request Jun 24, 2022
@wenfengwang
copy mwitkow#62
a3b0cb2
@wenfengwang wenfengwang mentioned this pull request Jun 24, 2022
Merged
4 tasks
@jshahriddhi jshahriddhi mentioned this pull request Aug 30, 2022
Merged
mattavos added a commit to mattavos/grpc-proxy that referenced this pull request Oct 27, 2022
@mattavos
Use Empty rather than Any for message processing.
e7cbd6f 
This fixes a bug where protobuf repeated fields are truncated to one
item.

See PR mwitkow#62
See issue mwitkow#61
@vito
Copy link

vito commented Nov 4, 2022 •
edited
Loading

@mwitkow Sorry to nag, but any chance this could be merged? 🙂 I ran into this issue as well.

edit: cc @bwplotka as I see you've merged something most recently 🙏

@vito vito mentioned this pull request Nov 4, 2022
Closed
10 tasks
@kpango kpango mentioned this pull request Nov 7, 2022
Merged
18 tasks
@floatingstatic
Copy link

Hi, I would also like to see if we can bump looking into merging this. For me this fixes both #59 and #61

Thanks!

@tzasacky
Copy link

Bump, I ran into this issue as well.

@dlakshma
Copy link

dlakshma commented Dec 26, 2022 •
edited
Loading

This fixes #61. This is also based off of #57
#59
Wanted to check the reason why this PR request is not merged. With the suggested fix "grpc: failed to unmarshal the received message string field contains invalid UTF-8" is not seen when querying the gRPC server using the grpc-proxy

@ghost
Copy link

ghost commented Jan 13, 2023

Thanks for the fix which saves my life! Though this hasn't been merged yet.

@andremarianiello
Copy link

I need this change too! Thanks!

@mwitkow
Copy link
Owner

mwitkow commented Feb 12, 2023

Hi folks, sorry for not looking into this earlier. I rarely read my github messages.

@mwitkow mwitkow merged commit f345521 into mwitkow:master Feb 12, 2023
@andremarianiello andremarianiello mentioned this pull request Jun 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fields marked as repeated are truncated

7 participants

@adamthesax @vito @floatingstatic @tzasacky @dlakshma @andremarianiello @mwitkow