-
Notifications
You must be signed in to change notification settings - Fork 38
Allow cancelling already running job #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dce72c6
to
dcc4750
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Bungeefan,
I've added some comments based on your questions. I don't think there is currently a way to get the user preferences without clearing the cache.
c63d640
to
5889915
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little more feedback and also for fixing the psalm errors just rebase this branch on main. The types were out of date and have been updated.
Signed-off-by: Severin Hamader <[email protected]>
Signed-off-by: Severin Hamader <[email protected]>
Signed-off-by: Severin Hamader <[email protected]>
Signed-off-by: Severin Hamader <[email protected]>
5889915
to
c4d4ee3
Compare
Co-authored-by: Lukas Schaefer <[email protected]> Signed-off-by: Severin <[email protected]>
As discussed in #277:
While working on the feature, I discovered that it is impossible to cancel an already running job.
As you may know, the "Cancel" button currently just sets some properties which are checked only once inside the job (at the beginning).
This PR adds a repeated check (for
importing_drive
) inside the import job to be able to gracefully stop it even while already importing files:NCU
namespace import, as the original (soon-to-be-deprecated?)IConfig
provides no way to bypass or even purge its cache.JobList
in case it is still in the queue.Regarding the experimental
NCU
import forIUserConfig
:Can/should I still use the experimental import for the time being, or will it stop working immediately when updating to the newest release? Or should this PR even be delayed until the API is officially released as stable?
Note: This PR is in the draft status as it is based on a previous PR of mine (#285), which would have to be merged before this one, besides that, it's ready to be reviewed!