Skip to content

test: add test for QUIC handshake against test client/server #60064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: add test for QUIC handshake against test client/server #60064

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Sep 28, 2025

No description provided.

@jasnell jasnell requested review from Qard and anonrig September 28, 2025 20:15
@jasnell jasnell added the quic Issues and PRs related to the QUIC implementation / HTTP/3. label Sep 28, 2025
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 28, 2025
@codecov Codecov
Copy link

codecov bot commented Sep 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (10df38a) to head (8253f1c).
⚠️ Report is 34 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60064      +/-   ##
==========================================
+ Coverage   88.45%   88.55%   +0.09%     
==========================================
  Files         703      703              
  Lines      207834   207833       -1     
  Branches    40037    40030       -7     
==========================================
+ Hits       183844   184041     +197     
+ Misses      15967    15795     -172     
+ Partials     8023     7997      -26

see 45 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivikr
trivikr requested changes Sep 29, 2025
View reviewed changes
@Qard
Copy link
Member

Qard commented Sep 29, 2025

Other than the already mentioned test failure, LGTM.

@abmusse abmusse mentioned this pull request Sep 30, 2025
Merged
@jasnell jasnell force-pushed the jasnell/test-quic-handshake branch from 98caea6 to 5946d0e Compare October 4, 2025 13:19
@jasnell jasnell requested a review from trivikr October 4, 2025 13:20
@jasnell jasnell force-pushed the jasnell/test-quic-handshake branch from 5946d0e to 8253f1c Compare October 5, 2025 12:56
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69571/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau left review comments

@anonrig anonrig anonrig approved these changes

@Qard Qard Awaiting requested review from Qard

@trivikr trivikr Awaiting requested review from trivikr

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasnell @Qard @nodejs-github-bot @anonrig @richardlau @trivikr