Skip to content

Conversation

avsm
Copy link
Member

@avsm avsm commented Sep 27, 2025

CHANGES:

- Fix use-after-free data race in CQE handlers (@avsm ocaml-multicore/ocaml-uring#124, reported ocaml-multicore/ocaml-uring#123 by @polytypic).

- Add socket bind and listen operations (@avsm ocaml-multicore/ocaml-uring#118).

- Update liburing to 2.7 (@avsm ocaml-multicore/ocaml-uring#118).

- Add `Uring.Setup_flags` module (@talex5 ocaml-multicore/ocaml-uring#122).

- Clean up configurator code and update primitives.h (@talex5 ocaml-multicore/ocaml-uring#121).

- Add `mkdirat` operation (@patricoferris ocaml-multicore/ocaml-uring#120).
@mseri
Copy link
Member

mseri commented Sep 29, 2025

Thanks!
Are the following failures something we should worry about?

  • riscv6: the tests are failing due to Tiemout of the CI (240min)
  • alpine tests are failing with
# File "tests/main.md", line 1, characters 0-0:
# /usr/bin/git --no-pager diff --no-index --color=always -u _build/default/tests/main.md _build/default/tests/.mdx/main.md.corrected
# diff --git a/_build/default/tests/main.md b/_build/default/tests/.mdx/main.md.corrected
# index d3158ac..4cd2e98 100644
# --- a/_build/default/tests/main.md
# +++ b/_build/default/tests/.mdx/main.md.corrected
# @@ -878,7 +878,7 @@ val t : [ `Mkdir of int ] Uring.t = <abstr>
#  - : [ `Mkdir of int ] Uring.completion_option =
#  Uring.Some {Uring.result = 0; data = `Mkdir 0}
#  # (Unix.stat "mkdir").st_perm;;
# -- : int = 448
# +- : int = 1472
#  # let v = Uring.mkdirat t ~mode:0o755 "mkdir" (`Mkdir 1);;
#  val v : [ `Mkdir of int ] Uring.job option = Some <abstr>
#  # Uring.submit t;;

@mseri mseri added the question label Sep 29, 2025
@avsm
Copy link
Member Author

avsm commented Sep 30, 2025

It's fixed in uring trunk and is just a small test problem, so it's fine to merge I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants