Skip to content

Conversation

arkirchner
Copy link
Contributor

The exercise administration form is a critical pass. The test will secure the functionality with the upcoming changes.

Relates to #2922

@arkirchner arkirchner self-assigned this Jul 8, 2025
@arkirchner arkirchner added the ruby Pull requests that update Ruby code label Jul 8, 2025
@arkirchner arkirchner force-pushed the ak/system_test_exercise_form branch 2 times, most recently from e2d0d2a to 1deabb1 Compare July 8, 2025 14:08
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.35%. Comparing base (5acecc4) to head (370e5ab).
⚠️ Report is 63 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3008      +/-   ##
==========================================
+ Coverage   70.05%   70.35%   +0.30%     
==========================================
  Files         215      215              
  Lines        6846     7128     +282     
==========================================
+ Hits         4796     5015     +219     
- Misses       2050     2113      +63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arkirchner arkirchner marked this pull request as ready for review July 8, 2025 14:20
The exercise administration form is a critical pass. The test
will secure the functionality with the upcoming changes.

Relates to #2922
@arkirchner arkirchner force-pushed the ak/system_test_exercise_form branch from 1deabb1 to 5b124c0 Compare July 9, 2025 11:24
@arkirchner arkirchner requested a review from kkoehn July 15, 2025 07:50
Copy link
Contributor

@kkoehn kkoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good to me in general, I added a few nit-picky comments and suggestions

@arkirchner
Copy link
Contributor Author

@kkoehn Can I ask you to have another look?

Copy link
Contributor

@kkoehn kkoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@arkirchner arkirchner merged commit 152b140 into main Aug 5, 2025
21 of 23 checks passed
@arkirchner arkirchner deleted the ak/system_test_exercise_form branch August 5, 2025 18:46
arkirchner added a commit that referenced this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ruby Pull requests that update Ruby code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants