Skip to content

Conversation

JohannesHatke
Copy link

I saw that Attribute Definitions were missing so i added them.
I also added a few tests and changed the relevant ones.
The enum members now all contain a String for the name of the attribute.

jannes922 added a commit to jannes922/can-dbc that referenced this pull request May 26, 2025
@JohannesHatke JohannesHatke reopened this Aug 5, 2025
@marcelbuesing
Copy link
Collaborator

Hey Johannes, thank you for bearing with me. This looks great! Would you mind fixing those small CI issues?

@JohannesHatke
Copy link
Author

Sure, i'll get on that. Sorry for the open and close, just a misclick :D

@JohannesHatke
Copy link
Author

This is my first time working with github actions and unfortunately the rust toolchain that's used in the ci is very different from my local one (newest stable).
Thats why i deleted a lot in the deny.toml file. All of the warnings in the cargo deny actions are now depreceated.
The fmt changes made no sense to me, because without the take_till import it wont compile. Could you take a look at that?

@nyurik
Copy link
Member

nyurik commented Oct 18, 2025

I wonder if these would be better to do via the new lexer https://github.com/oxibus/can-dbc-pest - the structs might be similar, but all the lexing logic would be in the pest crate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants