Revbayes banner message not printed on Linux #6
+11
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that Revticulate did not work on my desktop Linux system. After a bit of digging, I found out that the function
callRev()
expects there to be 13 lines of banner code after executing a temp file. On my system (Fedora) this is not the case, leading to an error message, rendering the entire package non-functional.I implemented a quick and dirty check for this banner, to only remove these lines if present. Note: I have not tested it on MacOS or Windows. Could you please look into this?
Also, there was an issue with retrieving the file path of the temporary rev file, which I fixed (again, only tested on my system).
Best,
Mario