Fix zero characters #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix corrupt temp file path
in system2 command replace stdout = TRUE with ""
davidcerny
approved these changes
Oct 17, 2025
There was a problem hiding this comment.
Replacing stdout = TRUE by stdout = "" doesn't cause any obvious issues on macOS. I've also checked that the new code works with RevBayes versions both before and after PR #803 (which removed the header / banner), so there is no need to postpone the merge until the release of RevBayes v1.4.0.
This was referenced Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for bothering again with my Linux desktop.
While the main Revticulate commands worked after my fix from yesterday (#6 ), I could not execute the RevBayes code blocks because when Revticulate read the shell, it read in
\0characters. I tried a ton of ways of how to filter them out but it either broke the package build or the\0characters were not removed. Then, I stumbled over this post. Simply replacingstdout = TRUEtostdout = ""did the trick for me. But, I don't know whether this would break the package on Windows or MacOS.Sorry for the messy pull request, I had to buid upon my branch from yesterday.