-
Notifications
You must be signed in to change notification settings - Fork 121
feat(serverless): pass runner name, namespace to runner #3056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(serverless): pass runner name, namespace to runner #3056
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Claude encountered an error —— View job I'll analyze this and get back to you. |
commit: |
24806c0
to
8cb89d0
Compare
Claude encountered an error —— View job I'll analyze this and get back to you. |
runner_name.clone(), | ||
namespace_name.clone(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a parameter name/value mismatch in this function call. The function signature expects a parameter named namespace_id_string
, but you're passing namespace_name.clone()
.
For consistency, either:
- Change the parameter name in the function signature from
namespace_id_string
tonamespace_name
, or - Pass the namespace ID as a string instead of the namespace name:
ns_id.to_string()
This will ensure the parameter name accurately reflects the data being passed.
runner_name.clone(), | |
namespace_name.clone(), | |
runner_name.clone(), | |
ns_id.to_string(), | |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Fixes KIT-332 (merge with rivet-dev/engine#3056)
8cb89d0
to
cdb5b2c
Compare
Claude encountered an error —— View job I'll analyze this and get back to you. |
cdb5b2c
to
89513bc
Compare
Claude encountered an error —— View job I'll analyze this and get back to you. |
Merge activity
|
Fixes KIT-332 (merge with rivet-dev/rivetkit#1335)
Fixes KIT-332 (merge with rivet-dev/rivetkit#1335)