Skip to content

Conversation

abcxff
Copy link
Contributor

@abcxff abcxff commented Oct 2, 2025

Fixes KIT-332 (merge with rivet-dev/rivetkit#1335)

Copy link

vercel bot commented Oct 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rivet-cloud Ready Ready Preview Comment Oct 6, 2025 8:18pm
rivet-inspector Ready Ready Preview Comment Oct 6, 2025 8:18pm
rivet-site Ready Ready Preview Comment Oct 6, 2025 8:18pm

Copy link
Contributor Author

abcxff commented Oct 2, 2025


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

claude bot commented Oct 2, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

Copy link

pkg-pr-new bot commented Oct 2, 2025

Open in StackBlitz

npm i https://pkg.pr.new/rivet-dev/engine/@rivetkit/engine-runner@3056
npm i https://pkg.pr.new/rivet-dev/engine/@rivetkit/engine-runner-protocol@3056

commit: 89513bc

@abcxff abcxff force-pushed the 10-02-feat_serverless_pass_runner_name_namespace_to_runner branch from 24806c0 to 8cb89d0 Compare October 2, 2025 23:42
Copy link

claude bot commented Oct 2, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

@abcxff abcxff marked this pull request as ready for review October 2, 2025 23:43
Copy link

linear bot commented Oct 2, 2025

Comment on lines +171 to +175
runner_name.clone(),
namespace_name.clone(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a parameter name/value mismatch in this function call. The function signature expects a parameter named namespace_id_string, but you're passing namespace_name.clone().

For consistency, either:

  1. Change the parameter name in the function signature from namespace_id_string to namespace_name, or
  2. Pass the namespace ID as a string instead of the namespace name: ns_id.to_string()

This will ensure the parameter name accurately reflects the data being passed.

Suggested change
runner_name.clone(),
namespace_name.clone(),
runner_name.clone(),
ns_id.to_string(),

Spotted by Diamond

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

graphite-app bot pushed a commit to rivet-dev/rivetkit that referenced this pull request Oct 5, 2025
@abcxff abcxff force-pushed the 10-02-feat_serverless_pass_runner_name_namespace_to_runner branch from 8cb89d0 to cdb5b2c Compare October 5, 2025 20:08
Copy link

claude bot commented Oct 5, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

@NathanFlurry NathanFlurry force-pushed the 10-02-feat_serverless_pass_runner_name_namespace_to_runner branch from cdb5b2c to 89513bc Compare October 5, 2025 20:30
Copy link

claude bot commented Oct 5, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

Copy link
Contributor

graphite-app bot commented Oct 7, 2025

Merge activity

  • Oct 7, 8:55 PM UTC: jog1t added this pull request to the Graphite merge queue.
  • Oct 7, 8:56 PM UTC: CI is running for this pull request on a draft pull request (#3098) due to your merge queue CI optimization settings.
  • Oct 7, 8:57 PM UTC: Merged by the Graphite merge queue via draft PR: #3098.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants