Skip to content

fix(serverless): scale to 0, fix serverless slot count edgecase of destroying pending actor #3092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 10-06-fix_serverless_check_for_runner_config_when_looking_for_dc
Choose a base branch
from
Open

fix(serverless): scale to 0, fix serverless slot count edgecase of destroying pending actor #3092

wants to merge 1 commit into from
+106 −55

Conversation

MasterPtato
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Oct 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rivet-cloud Ready Ready Preview Comment Oct 8, 2025 0:09am
2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
rivet-inspector Ignored Ignored Preview Oct 8, 2025 0:09am
rivet-site Ignored Ignored Preview Oct 8, 2025 0:09am

@claude Claude
Copy link

claude bot commented Oct 7, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@MasterPtato Graphite App
Copy link
Contributor Author

MasterPtato commented Oct 7, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MasterPtato MasterPtato mentioned this pull request Oct 7, 2025
Open
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 7, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/rivet-dev/engine/@rivetkit/engine-runner@3092

npm i https://pkg.pr.new/rivet-dev/engine/@rivetkit/engine-runner-protocol@3092

commit: a82efeb

@MasterPtato MasterPtato force-pushed the 10-06-fix_serverless_check_for_runner_config_when_looking_for_dc branch from 345df58 to d235cd6 Compare October 7, 2025 17:51
@MasterPtato MasterPtato force-pushed the 10-06-fix_serverless_scale_to_0_fix_serverless_slot_count_edgecase_of_destroying_pending_actor branch from 65d1775 to af0617e Compare October 7, 2025 17:51
@claude Claude
Copy link

claude bot commented Oct 7, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude Claude
Copy link

claude bot commented Oct 7, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

This was referenced Oct 7, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Open
Open
@MasterPtato MasterPtato force-pushed the 10-06-fix_serverless_check_for_runner_config_when_looking_for_dc branch from d235cd6 to a737fc0 Compare October 7, 2025 21:34
@MasterPtato MasterPtato force-pushed the 10-06-fix_serverless_scale_to_0_fix_serverless_slot_count_edgecase_of_destroying_pending_actor branch from af0617e to 5f96945 Compare October 7, 2025 21:34
@claude Claude
Copy link

claude bot commented Oct 7, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude Claude
Copy link

claude bot commented Oct 7, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@MasterPtato MasterPtato mentioned this pull request Oct 7, 2025
Open
@vercel vercel bot temporarily deployed to Preview – rivet-inspector October 7, 2025 22:07 Inactive
@vercel vercel bot temporarily deployed to Preview – rivet-site October 7, 2025 22:07 Inactive
@vercel vercel bot temporarily deployed to Preview – rivet-cloud October 7, 2025 22:07 Inactive
@NathanFlurry NathanFlurry force-pushed the 10-06-fix_serverless_check_for_runner_config_when_looking_for_dc branch from a737fc0 to 21083aa Compare October 7, 2025 22:42
@NathanFlurry NathanFlurry force-pushed the 10-06-fix_serverless_scale_to_0_fix_serverless_slot_count_edgecase_of_destroying_pending_actor branch from 5f96945 to 80fcaff Compare October 7, 2025 22:42
@claude Claude
Copy link

claude bot commented Oct 7, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude Claude
Copy link

claude bot commented Oct 7, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

This was referenced Oct 7, 2025
Open
Open
@vercel vercel bot temporarily deployed to Preview – rivet-cloud October 7, 2025 22:49 Inactive
@NathanFlurry NathanFlurry mentioned this pull request Oct 7, 2025
Open
@MasterPtato MasterPtato force-pushed the 10-06-fix_serverless_check_for_runner_config_when_looking_for_dc branch from 21083aa to a737fc0 Compare October 7, 2025 23:41
@MasterPtato MasterPtato force-pushed the 10-06-fix_serverless_scale_to_0_fix_serverless_slot_count_edgecase_of_destroying_pending_actor branch from 80fcaff to 5f96945 Compare October 7, 2025 23:41
@claude Claude
Copy link

claude bot commented Oct 7, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude Claude
Copy link

claude bot commented Oct 7, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@MasterPtato MasterPtato mentioned this pull request Oct 7, 2025
Open
@MasterPtato MasterPtato force-pushed the 10-06-fix_serverless_check_for_runner_config_when_looking_for_dc branch from a737fc0 to fa5504f Compare October 7, 2025 23:44
@MasterPtato MasterPtato force-pushed the 10-06-fix_serverless_scale_to_0_fix_serverless_slot_count_edgecase_of_destroying_pending_actor branch from 5f96945 to a82efeb Compare October 7, 2025 23:44
@claude Claude
Copy link

claude bot commented Oct 7, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude Claude
Copy link

claude bot commented Oct 7, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@MasterPtato MasterPtato mentioned this pull request Oct 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanFlurry NathanFlurry Awaiting requested review from NathanFlurry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MasterPtato