Skip to content

chore(ups): handle edge cases with postgres listen/unlisten/notify when disconnected/reconnecting #2893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

chore(ups): handle edge cases with postgres listen/unlisten/notify when disconnected/reconnecting #2893

wants to merge 3 commits into from

Conversation

@NathanFlurry
Copy link
Member

@NathanFlurry NathanFlurry commented Sep 9, 2025 •
edited
Loading

Fixes RVT-5131

This was referenced Sep 9, 2025
Merged
Closed
@vercel
Copy link

vercel bot commented Sep 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rivet-cloud Error Error Sep 15, 2025 6:07pm
rivet-site Ready Ready Preview Comment Sep 15, 2025 6:07pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
rivet-studio Ignored Ignored Preview Sep 15, 2025 6:07pm

This was referenced Sep 9, 2025
Closed
Closed
Closed
Closed
Closed
@NathanFlurry NathanFlurry mentioned this pull request Sep 9, 2025
Merged
@claude
Copy link

claude bot commented Sep 9, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented Sep 9, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@linear
Copy link

linear bot commented Sep 9, 2025

RVT-5131 Validate UPS reconnection logic for all drivers

@NathanFlurry NathanFlurry force-pushed the 09-08-chore_ups_handle_edge_cases_with_postgres_listen_unlisten_notify_when_disconnected_reconnecting branch from d217a5c to 17e3f16 Compare September 9, 2025 03:32
@claude
Copy link

claude bot commented Sep 9, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@NathanFlurry NathanFlurry force-pushed the 09-08-chore_ups_add_postgres_auto-reconnect branch from 3bd57c8 to ffc28d2 Compare September 9, 2025 03:38
@NathanFlurry NathanFlurry force-pushed the 09-08-chore_ups_handle_edge_cases_with_postgres_listen_unlisten_notify_when_disconnected_reconnecting branch from 17e3f16 to 664a377 Compare September 9, 2025 03:38
@claude
Copy link

claude bot commented Sep 9, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude
Copy link

claude bot commented Sep 9, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 9, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-runner@2893

npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-runner-protocol@2893

npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-tunnel-protocol@2893

commit: e29523a

@NathanFlurry NathanFlurry mentioned this pull request Sep 9, 2025
Closed
@NathanFlurry NathanFlurry mentioned this pull request Sep 9, 2025
Merged
@NathanFlurry NathanFlurry force-pushed the 09-08-chore_ups_add_postgres_auto-reconnect branch from ffc28d2 to 5fdffb7 Compare September 12, 2025 20:23
@NathanFlurry NathanFlurry force-pushed the 09-08-chore_ups_handle_edge_cases_with_postgres_listen_unlisten_notify_when_disconnected_reconnecting branch from 664a377 to 58f3f4e Compare September 12, 2025 20:23
@claude
Copy link

claude bot commented Sep 12, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@NathanFlurry NathanFlurry force-pushed the 09-08-chore_ups_handle_edge_cases_with_postgres_listen_unlisten_notify_when_disconnected_reconnecting branch from 58f3f4e to ba4a9b1 Compare September 14, 2025 20:00
@NathanFlurry NathanFlurry force-pushed the 09-08-chore_ups_add_postgres_auto-reconnect branch from 5fdffb7 to a509b73 Compare September 14, 2025 20:00
@claude
Copy link

claude bot commented Sep 14, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude
Copy link

claude bot commented Sep 14, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@NathanFlurry NathanFlurry mentioned this pull request Sep 14, 2025
Merged
@jog1t jog1t force-pushed the 09-08-chore_ups_add_postgres_auto-reconnect branch from a509b73 to 5fdffb7 Compare September 15, 2025 16:47
@jog1t jog1t force-pushed the 09-08-chore_ups_handle_edge_cases_with_postgres_listen_unlisten_notify_when_disconnected_reconnecting branch from ba4a9b1 to 58f3f4e Compare September 15, 2025 16:47
@claude
Copy link

claude bot commented Sep 15, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude
Copy link

claude bot commented Sep 15, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@jog1t jog1t mentioned this pull request Sep 15, 2025
Closed
@MasterPtato MasterPtato removed their request for review September 15, 2025 17:56
@MasterPtato MasterPtato force-pushed the 09-08-chore_ups_handle_edge_cases_with_postgres_listen_unlisten_notify_when_disconnected_reconnecting branch from 58f3f4e to e29523a Compare September 15, 2025 18:04
@MasterPtato MasterPtato force-pushed the 09-08-chore_ups_add_postgres_auto-reconnect branch from 5fdffb7 to 74e5db5 Compare September 15, 2025 18:04
@claude
Copy link

claude bot commented Sep 15, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude
Copy link

claude bot commented Sep 15, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

This was referenced Sep 15, 2025
Merged
Merged
@NathanFlurry NathanFlurry changed the base branch from 09-08-chore_ups_add_postgres_auto-reconnect to main September 16, 2025 01:39
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 16, 2025 •
edited
Loading

Merge activity

  • Sep 16, 1:40 AM UTC: NathanFlurry added this pull request to the Graphite merge queue.
  • Sep 16, 1:40 AM UTC: CI is running for this pull request on a draft pull request (#2923) due to your merge queue CI optimization settings.
  • Sep 16, 1:41 AM UTC: Merged by the Graphite merge queue via draft PR: #2923.

graphite-app bot pushed a commit that referenced this pull request Sep 16, 2025
@NathanFlurry
chore(ups): handle edge cases with postgres listen/unlisten/notify wh…
506246c 
…en disconnected/reconnecting (#2893)

Fixes RVT-5131
@graphite-app graphite-app bot closed this Sep 16, 2025
@graphite-app graphite-app bot deleted the 09-08-chore_ups_handle_edge_cases_with_postgres_listen_unlisten_notify_when_disconnected_reconnecting branch September 16, 2025 01:41
@github-actions github-actions bot mentioned this pull request Sep 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MasterPtato MasterPtato MasterPtato approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NathanFlurry @MasterPtato