Skip to content

Fix: Align PositionedContentProps style with Pressable style prop #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Align PositionedContentProps style with Pressable style prop #94

wants to merge 1 commit into from
+2 −2

Conversation

avivash
Copy link

@avivash avivash commented Jun 12, 2025 •
edited
Loading

Components using PositionedContentProps are having their style type definitions from normal Views and Pressables overwritten. PositionedContentProps are only typed to receive a single style object even though they actually work with arrays of style objects too

Pressable Props
View Props

Summary by CodeRabbit

  • New Features
    • Enhanced the flexibility of the style property in certain components to support a wider range of style formats, including arrays and other variations accepted by React Native.

@avivash
Fix: Align PositionedContentProps style with Pressable style prop
5ccb873 
Components using PositionedContentProps are only typed to receive a single style object even though they actually work with arrays of style objects too
@vercel Vercel
Copy link

vercel bot commented Jun 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rn-primitives ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2025 5:51pm

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 12, 2025 •
edited
Loading

Walkthrough

The type of the style property in the PositionedContentProps interface was updated from ViewStyle to StyleProp<ViewStyle>, and the corresponding import was adjusted to include StyleProp from react-native. This change allows the style prop to accept a wider range of style values.

Changes

File Change Summary
packages/types/src/index.ts Updated import to include StyleProp; changed PositionedContentProps.style to StyleProp<ViewStyle>.

Sequence Diagram(s)

sequenceDiagram
    participant Consumer as Component Consumer
    participant PositionedContent as PositionedContent Component

    Consumer->>PositionedContent: Passes style prop (StyleProp<ViewStyle>)
    PositionedContent-->>PositionedContent: Accepts style as StyleProp<ViewStyle>
    PositionedContent-->>Consumer: Renders with applied style
Loading
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4c0539f and 5ccb873.

📒 Files selected for processing (1)
  • packages/types/src/index.ts (2 hunks)
🔇 Additional comments (2)
packages/types/src/index.ts (2)

1-1: Import update looks good.

Adding StyleProp to the react-native import list is required for the new prop typing and does not introduce any side-effects.

39-39: Accurate widening of the style prop type.

Switching from ViewStyle to StyleProp<ViewStyle> correctly allows single styles, arrays, and null/false branches, matching how React Native handles styles. No further action required.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

mrzachnugent
mrzachnugent requested changes Aug 9, 2025
View reviewed changes
packages/types/src/index.ts
interface PositionedContentProps {
forceMount?: true | undefined;
style?: ViewStyle;
style?: StyleProp<ViewStyle>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this changes to type, the code that implements it will not handle StyleProp<ViewStyle> properly.

To make this work, every Content component that extends this type for its props needs to handle cases where it is not just a ViewStyle.

@mrzachnugent
Copy link
Collaborator

@avivash Thanks for contributing. I left a comment to be able to merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrzachnugent mrzachnugent mrzachnugent requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avivash @mrzachnugent