Skip to content

Fix: Align PositionedContentProps style with Pressable style prop #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Fix: Align PositionedContentProps style with Pressable style prop #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/types/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Pressable, Text, View, ViewStyle } from 'react-native';
import type { Pressable, StyleProp, Text, View, ViewStyle } from 'react-native';

type ComponentPropsWithAsChild<T extends React.ElementType<any>> =
React.ComponentPropsWithoutRef<T> & { asChild?: boolean };
Expand Down Expand Up @@ -36,7 +36,7 @@ type FocusOutsideEvent = CustomEvent<{ originalEvent: FocusEvent }>;
*/
interface PositionedContentProps {
forceMount?: true | undefined;
style?: ViewStyle;
style?: StyleProp<ViewStyle>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this changes to type, the code that implements it will not handle StyleProp<ViewStyle> properly.

To make this work, every Content component that extends this type for its props needs to handle cases where it is not just a ViewStyle.

alignOffset?: number;
insets?: Insets;
avoidCollisions?: boolean;
Expand Down