Skip to content

Improve autogenerated materials #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Improve autogenerated materials #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38d3783
Connect UVW input for cube/array texture samplers
Th3Fanbus Nov 9, 2024
3e497c4
Improve domain-specific material generation
Th3Fanbus Nov 9, 2024
bbece7e
Do some lessening of terriblenesses
Th3Fanbus Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 44 additions & 5 deletions ...tGenerator/Source/AssetGenerator/Private/Toolkit/AssetTypeGenerator/MaterialGenerator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#include "Engine/Texture.h"
#include "Engine/Texture2DArray.h"
#include "Kismet2/BlueprintEditorUtils.h"
#include "MaterialDomain.h"
#include "MaterialEditor/Public/MaterialEditingLibrary.h"
#include "MaterialGraph/MaterialGraphNode_Comment.h"
#include "Materials/Material.h"
Expand All @@ -15,6 +16,7 @@
#include "Materials/MaterialExpressionLandscapeGrassOutput.h"
#include "Materials/MaterialExpressionMultiply.h"
#include "Materials/MaterialExpressionQualitySwitch.h"
#include "Materials/MaterialExpressionReflectionVectorWS.h"
#include "Materials/MaterialExpressionRuntimeVirtualTextureSampleParameter.h"
#include "Materials/MaterialExpressionScalarParameter.h"
#include "Materials/MaterialExpressionStaticSwitchParameter.h"
Expand Down Expand Up @@ -297,6 +299,10 @@ UClass* GetTextureSampleParameterClassForTexture(UTexture* Texture) {
return NULL;
}

FORCEINLINE static bool DoesTextureSamplerRequireUVW(UClass* ExpressionClass) {
return ExpressionClass->IsChildOf<UMaterialExpressionTextureSampleParameterCube>() || ExpressionClass->IsChildOf<UMaterialExpressionTextureSampleParameter2DArray>();
}

void UMaterialGenerator::ApplyOtherLayoutChanges(UMaterial* Material, FMaterialLayoutChangeInfo& LayoutChangeInfo) {
//Add Parameter Collection parameter nodes
for (UMaterialParameterCollection* NewCollection : LayoutChangeInfo.NewReferencedParameterCollections) {
Expand Down Expand Up @@ -481,6 +487,12 @@ void UMaterialGenerator::SpawnNewMaterialParameterNodes(UMaterial* Material, FMa
Expression->SetParameterName(NewTextureParameter.ParameterInfo.Name);
Expression->Texture = NewTextureParameter.ParameterValue.Get();
Expression->AutoSetSampleType();

if (DoesTextureSamplerRequireUVW(ExpressionClass)) {
const FVector2D NodePos = FVector2D(Expression->MaterialExpressionEditorX - 256, Expression->MaterialExpressionEditorY);
UMaterialExpressionReflectionVectorWS* ReflectionVector = SpawnMaterialExpression<UMaterialExpressionReflectionVectorWS>(Material, NodePos);
Expression->Coordinates.Connect(0, ReflectionVector);
}
}
}

Expand Down Expand Up @@ -670,20 +682,47 @@ void DisconnectIfExpressionMissing(FExpressionInput& Input, UMaterial* Material)
}
}

static bool PreferEmissiveColor(EMaterialDomain Domain) {
return Domain == EMaterialDomain::MD_PostProcess || Domain == EMaterialDomain::MD_UI;
}

void UMaterialGenerator::TryConnectBasicMaterialPins(UMaterial* Material) {
FExpressionInput& BaseColorInput = Material->GetEditorOnlyData()->BaseColor;
FExpressionInput& NormalInput = Material->GetEditorOnlyData()->Normal;
FExpressionInput& EmissiveColorInput = Material->GetEditorOnlyData()->EmissiveColor;

DisconnectIfExpressionMissing(BaseColorInput, Material);
DisconnectIfExpressionMissing(NormalInput, Material);
DisconnectIfExpressionMissing(EmissiveColorInput, Material);

if (Material->MaterialDomain == EMaterialDomain::MD_PostProcess) {
const FVector2D NodePos = FVector2D(Material->EditorX - 384, Material->EditorY);
// This terribleness is necessary because UMaterialExpressionSceneTexture
// is not exported at all, so there is no way to use the type directly...
UPackage* EngineScriptPackage = FindPackage(NULL, UMaterialExpressionSceneTexture::StaticPackage());
TSubclassOf<UMaterialExpression> SceneTextureExpressionClass = FindObjectChecked<UClass>(EngineScriptPackage, TEXT("MaterialExpressionSceneTexture"));
UMaterialExpressionSceneTexture* SceneTextureExpression = static_cast<UMaterialExpressionSceneTexture*>(SpawnMaterialExpression<UMaterialExpression>(Material, NodePos, SceneTextureExpressionClass));
SceneTextureExpression->SceneTextureId = PPI_PostProcessInput0;
EmissiveColorInput.Connect(0, SceneTextureExpression);
return;
}

FExpressionInput& ColorInput = PreferEmissiveColor(Material->MaterialDomain) ? EmissiveColorInput : BaseColorInput;

for (UMaterialExpression* Expression : Material->GetExpressions()) {
if (UMaterialExpressionTextureSample* TextureSample = Cast<UMaterialExpressionTextureSample>(Expression)) {
if ((TextureSample->SamplerType == SAMPLERTYPE_Color || TextureSample->SamplerType == SAMPLERTYPE_LinearColor) && !BaseColorInput.IsConnected()) {
BaseColorInput.Connect(0, TextureSample);
}
else if (TextureSample->SamplerType == SAMPLERTYPE_Normal && !NormalInput.IsConnected()) {
NormalInput.Connect(0, TextureSample);
switch (TextureSample->SamplerType) {
case SAMPLERTYPE_Color:
case SAMPLERTYPE_LinearColor:
if (!ColorInput.IsConnected()) {
ColorInput.Connect(0, TextureSample);
}
break;
case SAMPLERTYPE_Normal:
if (!NormalInput.IsConnected()) {
NormalInput.Connect(0, TextureSample);
}
break;
}
}
}
Expand Down
14 changes: 10 additions & 4 deletions AssetGenerator/Source/AssetGenerator/Public/Toolkit/AssetTypeGenerator/MaterialGenerator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,15 +149,21 @@ class UMaterialGenerator : public UAssetTypeGenerator {
static FVector2D GetGoodPlaceForNewMaterialExpression(UMaterial* Material);
static void ForceMaterialCompilation(UMaterial* Material);
static void ConnectBasicParameterPinsIfPossible(UMaterial* Material, const FString& ErrorMessage);

template<typename T>
FORCEINLINE static T* SpawnMaterialExpression(UMaterial* Material, UClass* ExpressionClass = T::StaticClass()) {
const FVector2D NodePos = GetGoodPlaceForNewMaterialExpression(Material);
T* NewMaterialExpression = CastChecked<T>(UMaterialEditingLibrary::CreateMaterialExpressionEx(Material, NULL, ExpressionClass, NULL, NodePos.X, NodePos.Y));
FORCEINLINE static T* SpawnMaterialExpression(UMaterial* Material, const FVector2D NodePos, UClass* ExpressionClass = T::StaticClass())
{
T* NewMaterialExpression = CastChecked<T>(UMaterialEditingLibrary::CreateMaterialExpressionEx(Material, NULL, ExpressionClass, NULL, NodePos.X, NodePos.Y));

if (Material->MaterialGraph) {
Material->MaterialGraph->AddExpression(NewMaterialExpression, false);
}
return NewMaterialExpression;
}

template<typename T>
FORCEINLINE static T* SpawnMaterialExpression(UMaterial* Material, UClass* ExpressionClass = T::StaticClass())
{
return SpawnMaterialExpression<T>(Material, GetGoodPlaceForNewMaterialExpression(Material), ExpressionClass);
}
};