Skip to content

Conversation

Aryan51203
Copy link

No description provided.

@Aryan51203
Copy link
Author

PR for issue #371

@sukhman-sukh sukhman-sukh changed the base branch from master to multiple_servers February 4, 2025 17:45
@v1bh475u
Copy link
Contributor

v1bh475u commented Feb 4, 2025

@Aryan51203 I have review your commits and suggested some changes. Please go through them.

@v1bh475u
Copy link
Contributor

v1bh475u commented Feb 5, 2025

@Aryan51203 Please do these small changes and I guess we are done

@v1bh475u
Copy link
Contributor

v1bh475u commented Feb 5, 2025

#370 (comment) this is left

@v1bh475u
Copy link
Contributor

v1bh475u commented Feb 5, 2025

LGTM

@sukhman-sukh
Copy link
Contributor

Did you test every feature of this PR with the frontend?

@v1bh475u
Copy link
Contributor

v1bh475u commented Feb 5, 2025

I have only done code review. Please do the testing if you are free.

@sukhman-sukh
Copy link
Contributor

Ok ok.

@sukhman-sukh
Copy link
Contributor

Hey @Aryan51203,
I forgot the context of this PR.
Can you check once what is implemented here and is that in out latest blaze/dev PR already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants