Fixed issue #21 bad error when no data is present #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To do testing for this this file can be used: /data/rjanusia/IrisHep/DAOD_LLP1_noDATA.outputLLP1.root" |
ArturU043
requested changes
Oct 9, 2025
| if arrays: | ||
| awk_arrays[sample] = ak.concatenate(arrays) | ||
| else: | ||
| raise RuntimeError( |
There was a problem hiding this comment.
This would be more of a ValueError
| list(iterators) | ||
| ) # return array | ||
|
|
||
| arrays = list(iterators) |
There was a problem hiding this comment.
We should rename this var to something like iterator_list, which would make more sense
|
Yesterday, there was a specific issue in af Uchicago for accessing /data |
|
Maybe we should add a raise error test in test_materialization? |
|
Related to #21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is no data for a root file that does not use iterator it gives a gross error that Is not easy to understand. This way when there is no data in the file it gives error that makes it clear that is the problem.