Skip to content

Fixed issue #21 bad error when no data is present #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixed issue #21 bad error when no data is present #29

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed1ba7c
Added the ability to check to make sure a file is not empty for not i…
RogerJanusiak Oct 8, 2025
6e312fe
Moved it to raise an error and not return no data
RogerJanusiak Oct 8, 2025
3fcfd0b
Fixed black
RogerJanusiak Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions servicex_analysis_utils/materialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,13 @@ def to_awk(deliver_dict, dask=False, iterator=False, **kwargs):
if iterator == True:
awk_arrays[sample] = iterators # return iterators
else:
awk_arrays[sample] = ak.concatenate(
list(iterators)
) # return array

arrays = list(iterators)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should rename this var to something like iterator_list, which would make more sense

if arrays:
awk_arrays[sample] = ak.concatenate(arrays)
else:
raise RuntimeError(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be more of a ValueError

f"No arrays yielded for sample {sample}. Check file content or TTree name."
)
else:
# file is parquet
awk_arrays[sample] = ak.from_parquet(paths, **kwargs)
Expand Down