FoundationEssentials: retry with modified permissions #1494
Conversation
On an access denied, reset the system permissions and retry the rename. The original variant seemed to work, this reduces some of the complexity in the hopes that it is sufficiently robust.
|
@swift-ci please test |
|
@swift-ci please build toolchain windows platform |
There was a problem hiding this comment.
Discussed with @parkera and we'd like to spend more time investigating this issue to come to a more understood solution. While resetting these file attributes does solve the problem, my understanding is that we don't have a clear picture of why exactly and it feels incorrect to me that we should unconditionally make a file writeable/non-hidden/non-system when writing if we failed to perform the write. If we can figure out more about what's happening here and better understand the root cause, we can confirm if this is the required approach (and perhaps limit its effects) or determine if there are other solutions. I've filed #1507 that we'll use to continue investigation into this issue
2 participants
On an access denied, reset the system permissions and retry the rename. The original variant seemed to work, this reduces some of the complexity in the hopes that it is sufficiently robust.