Skip to content

FoundationEssentials: retry with modified permissions #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −0
Open

FoundationEssentials: retry with modified permissions #1494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions Sources/FoundationEssentials/Data/Data+Writing.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,19 @@ private func writeToFileAux(path inPath: PathOrURL, buffer: UnsafeRawBufferPoint

if !SetFileInformationByHandle(hFile, FileRenameInfoEx, pInfo, dwSize) {
let dwError = GetLastError()
if dwError == ERROR_ACCESS_DENIED {
let dwAttributes = GetFileAttributesW(pwszPath)
if dwAttributes > 0,
dwAttributes & (FILE_ATTRIBUTE_READONLY | FILE_ATTRIBUTE_HIDDEN | FILE_ATTRIBUTE_SYSTEM) != 0 {
if SetFileAttributesW(pwszPath, dwAttributes & ~(FILE_ATTRIBUTE_READONLY | FILE_ATTRIBUTE_HIDDEN | FILE_ATTRIBUTE_SYSTEM)) {
if SetFileInformationByHandle(hFile, FileRenameInfoEx, pInfo, dwSize) {
return
}
// Try to restore the attributes, but ignore any error
_ = SetFileAttributesW(pwszPath, dwAttributes)
}
}
}
guard dwError == ERROR_NOT_SAME_DEVICE else {
throw CocoaError.errorWithFilePath(inPath, win32: dwError, reading: false)
}
Expand Down
7 changes: 7 additions & 0 deletions Sources/FoundationEssentials/WinSDK+Extensions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,18 @@ package var FILE_ATTRIBUTE_READONLY: DWORD {
DWORD(WinSDK.FILE_ATTRIBUTE_READONLY)
}

package var FILE_ATTRIBUTE_HIDDEN: DWORD {
DWORD(WinSDK.FILE_ATTRIBUTE_HIDDEN)
}

package var FILE_ATTRIBUTE_REPARSE_POINT: DWORD {
DWORD(WinSDK.FILE_ATTRIBUTE_REPARSE_POINT)
}

package var FILE_ATTRIBUTE_SYSTEM: DWORD {
DWORD(WinSDK.FILE_ATTRIBUTE_SYSTEM)
}

package var FILE_FLAG_BACKUP_SEMANTICS: DWORD {
DWORD(WinSDK.FILE_FLAG_BACKUP_SEMANTICS)
}
Expand Down