Cleanup some unnecessary build setting #9234
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
daveinglis
commented
Oct 9, 2025
daveinglis
commented
- fix adding -lc++ to OTHER_LDFLAGS to match native build system.
- remove OTHER_LDRFLAGS setting
- fix adding -lc++ to OTHER_LDFLAGS to match native build system. - remove OTHER_LDRFLAGS setting
|
@swift-ci test |
owenv
approved these changes
Oct 9, 2025
jakepetroules
approved these changes
Oct 9, 2025
jakepetroules
requested changes
Oct 9, 2025
| // We currently deliberately do not support Swift ObjC interface headers. | ||
| settings[.SWIFT_INSTALL_OBJC_HEADER] = "NO" | ||
| settings[.SWIFT_OBJC_INTERFACE_HEADER_NAME] = "" | ||
| settings[.OTHER_LDRFLAGS] = [] |
There was a problem hiding this comment.
This is set because OTHER_LDRFLAGS defaults to OTHER_LDFLAGS, and this might've been on purpose if we wanted to set linker flags without those applying to ld -r invocations (e.g. when producing mh_objects).
Let's double check whether we actually mean to remove this, and if not, document via a code comment why it's empty.
There was a problem hiding this comment.
Looks like the original purpose was to avoid trying to link frameworks when producing object files as part of ld -r.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.