feat: added board title #1454
Closed
feat: added board title #1454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jayantpranjal0 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
seveibar
reviewed
Oct 7, 2025
|
@seveibar made appropriate changes |
seveibar
approved these changes
Oct 7, 2025
|
@jayantpranjal0 you need to add title support to circuit json in order to use this in a pinout diagram |
|
Board already has a name, it doesn't need a title. I'm PR'ing to remove the title from props |
|
Ok never mind, it's the difference between a display name and a variable name 👍 |
|
@jayantpranjal0 you will need to insert source_board with source_board.title (this will be available in a version of circuit json being released shortly) |
jayantpranjal0
force-pushed
the
f/board_title
branch
from
1d9bf4b to
f1c562c
Compare
|
@seveibar this PR became a bit messy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref tscircuit/tscircuit#895