-
Notifications
You must be signed in to change notification settings - Fork 78
feat: added board title #1454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
feat: added board title #1454
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
554fabc
feat: added board title
jayantpranjal0 dffb7fa
add test into a seperate file
jayantpranjal0 c93e955
fix graphite errors and formatting
jayantpranjal0 a74f439
update @tscircuitbot/props version
jayantpranjal0 5eebb7b
remove type casting
jayantpranjal0 71db826
remove type casting
jayantpranjal0 f1c562c
add source_board support for Board.ts
jayantpranjal0 094e5af
Merge branch 'main' into f/board_title
jayantpranjal0 39375a3
bump circuit-json
jayantpranjal0 3ccdb37
update source board type
jayantpranjal0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import { test, expect } from "bun:test" | ||
import { getTestFixture } from "tests/fixtures/get-test-fixture" | ||
|
||
test("board title appears in silkscreen", () => { | ||
const { circuit } = getTestFixture({ | ||
platform: { | ||
printBoardInformationToSilkscreen: true, | ||
}, | ||
}) | ||
|
||
circuit.add( | ||
<board width="20mm" height="20mm" title="My Custom Board"> | ||
<resistor name="R1" resistance="10k" footprint="0402" /> | ||
</board>, | ||
) | ||
|
||
circuit.render() | ||
|
||
const silkscreenTexts = circuit.db.pcb_silkscreen_text.list() | ||
const titleText = silkscreenTexts.find((text) => | ||
text.text.includes("My Custom Board"), | ||
) | ||
|
||
expect(titleText).toBeDefined() | ||
expect(titleText?.text).toContain("My Custom Board") | ||
expect(titleText?.layer).toBe("top") | ||
}) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.