Skip to content

fix(schematic): Fixes port rendering issue with custom symbols #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+31 −10
Open

fix(schematic): Fixes port rendering issue with custom symbols #1472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f276fc
Fix issue
Excellencedev Oct 10, 2025
3286b48
Type error
Excellencedev Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions lib/components/primitive-components/Port/Port.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,26 +316,40 @@ export class Port extends PrimitiveComponent<typeof portProps> {

doInitialSourceParentAttachment(): void {
const { db } = this.root!
if (!this.parent?.source_component_id) {
let source_component_id = this.parent?.source_component_id
let current = this.parent
while (current && !source_component_id) {
current = current.parent
source_component_id = current?.source_component_id
}

if (!source_component_id) {
throw new Error(
`${this.getString()} has no parent source component (parent: ${this.parent?.getString()})`,
)
}

db.source_port.update(this.source_port_id!, {
source_component_id: this.parent?.source_component_id!,
source_component_id: source_component_id!,
subcircuit_id: this.getSubcircuit()?.subcircuit_id!,
})

this.source_component_id = this.parent?.source_component_id
this.source_component_id = source_component_id
}

doInitialPcbPortRender(): void {
if (this.root?.pcbDisabled) return
const { db } = this.root!
const { matchedComponents } = this

if (!this.parent?.pcb_component_id) {
let pcb_component_id = this.parent?.pcb_component_id
let current = this.parent
while (current && !pcb_component_id) {
current = current.parent
pcb_component_id = current?.pcb_component_id
}

if (!pcb_component_id) {
throw new Error(
`${this.getString()} has no parent pcb component, cannot render pcb_port (parent: ${this.parent?.getString()})`,
)
Expand Down Expand Up @@ -366,7 +380,7 @@ export class Port extends PrimitiveComponent<typeof portProps> {
const isBoardPinout = this._shouldIncludeInBoardPinout()

const pcb_port = db.pcb_port.insert({
pcb_component_id: this.parent?.pcb_component_id!,
pcb_component_id: pcb_component_id!,
layers: this.getAvailablePcbLayers(),
subcircuit_id: subcircuit?.subcircuit_id ?? undefined,
pcb_group_id: this.getGroup()?.pcb_group_id ?? undefined,
Expand Down
Loading