Skip to content

Conversation

@qclayssen
Copy link
Collaborator

@qclayssen qclayssen commented Sep 15, 2025

Add

Upgrade

* update doc

*  bump  gpgr version
@qclayssen qclayssen self-assigned this Sep 15, 2025
qclayssen and others added 9 commits September 23, 2025 17:00
* Bump version: 0.2.15 → 0.2.16

* Change hrd facultative for cancer report (#17)

* change hrd file facultatif

* fix arg position and assign default value

* fix version (#18)

* Bump gpgr version to 2.2.0
* Bump version: 0.2.16 → 0.2.17

* bump gpgr to v2.2.1 in docker files (#21)
@qclayssen qclayssen force-pushed the release/0.3.0 branch 2 times, most recently from 54672c1 to 9c613d4 Compare October 17, 2025 00:38
@qclayssen qclayssen requested a review from Copilot October 24, 2025 00:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades PCGR from v1.4.1 to v2.2.1 and adds handling for hypermutated samples. The upgrade requires updating field names and annotations to match the new PCGR version's output format, while new functionality filters variants in hypermutated samples to stay within PCGR's variant count limits.

Key changes:

  • Updated PCGR/CPSR field names to match v2.2.1 output (e.g., PCGR_TIERPCGR_ACTIONABILITY_TIER)
  • Added hypermutation handling with variant filtering logic for samples exceeding 450,000 variants
  • Implemented chunked PCGR processing for large variant sets with parallel execution

Reviewed Changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
pyproject.toml Version bump to 0.2.17
docker/Dockerfile.pcgr Updated PCGR conda environment from v1.4.1 to v2.2.1
docker/Dockerfile.gpgr Updated r-gpgr from 2.1.3 to 2.2.11
conda/env/bolt_env.yml Added ncurses dependency
bolt/workflows/sv_somatic/annotate.py Added logging infrastructure
bolt/workflows/smlv_somatic/rescue.py Added logging infrastructure
bolt/workflows/smlv_somatic/report.py Added hypermutation variant filtering and updated PCGR integration
bolt/workflows/smlv_somatic/filter.py Updated field names for PCGR v2.2.1 and added helper function to handle missing values
bolt/workflows/smlv_somatic/annotate.py Refactored PCGR processing to support chunking and updated field names
bolt/workflows/smlv_germline/report.py Added logging and vep_dir parameter
bolt/workflows/other/cancer_report.py Made dragen_hrd_fp optional and added new signature analysis parameters
bolt/util.py Enhanced command execution with logging, added VCF splitting/merging utilities
bolt/logging_config.py New logging configuration module
bolt/common/pcgr.py Major refactor for PCGR v2.2.1 compatibility, chunked processing, and updated field mappings
bolt/common/constants.py Updated field names and added hypermutation filtering constants
tests/test_smlv_somatic_filter.py Updated test data to match new PCGR field names
README.md Updated version references to 0.2.17
CHANGELOG.md Added changelog entries for recent PRs
.bumpversion.cfg Updated version to 0.2.17
Comments suppressed due to low confidence (1)

bolt/common/pcgr.py:1

  • Missing spaces around the == operator. Should be if value == '' or value == '.':
import collections

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.


# NOTE(SW): GIAB_CONF always overrides DIFFICULT tags
if data['giab_conf'] and data['difficult']:
data['difficult']= False
Copy link

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space before the = operator. Should be data['difficult'] = False

Suggested change
data['difficult']= False
data['difficult'] = False

Copilot uses AI. Check for mistakes.
--img_dir {output_image_dir}/ \
--result_outdir {output_table_dir}/ \
--out_file {output_dir}/{kwargs["tumor_name"]}.cancer_report.html
--out_file {output_dir}/{kwargs['tumor_name']}.cancer_report.html
Copy link

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Inconsistent quote usage in f-string. Line 118 uses double quotes inside curly braces while line 106 uses single quotes. For consistency, use single quotes: {kwargs['tumor_name']}

Copilot uses AI. Check for mistakes.
CHANGELOG.md Outdated
- [6](https://github.com/umccr/bolt/pull/6) - Change oncoanalyser v2.0.0 uptade, with switch sv caller from GRIPSS to eSVee
- [6](https://github.com/umccr/bolt/pull/6) - Change oncoanalyser v2.0.0 uptade, with switch sv caller from GRIPSS to eSVee

-[9](https://github.com/umccr/bolt/pull/9) Add hypermutation sample handling
Copy link

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space after the hyphen. Should be - [9] for consistency with other entries.

Suggested change
-[9](https://github.com/umccr/bolt/pull/9) Add hypermutation sample handling
- [9](https://github.com/umccr/bolt/pull/9) Add hypermutation sample handling

Copilot uses AI. Check for mistakes.
* update "HIGH_INF_POS" to "HIGH_I_I_POS" in VCF header for latest pcgr version

* update constant for pcgr 2.2.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants