-
Notifications
You must be signed in to change notification settings - Fork 67
perf[duckdb]: fsl canonicalize the list view once #4759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Joe Isaacs <[email protected]>
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Hmm, maybe we want an exporter that slices and canonicalizes? |
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Do we know why this fixes things? Shouldn't Edit: Not sure if you're also doing this, but I just traced through the |
Added another simpler test in #4753 that hits the same assertion as before, but now instead of |
I think the problem is that recursive datatypes require uncompressed/flat vectors, our exporters can return non-flat vectors, if we canon, then we will only use exporters which produce flat vectors since canon <==> flat |
No description provided.