Skip to content

perf[duckdb]: fsl canonicalize the list view once #4759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

perf[duckdb]: fsl canonicalize the list view once #4759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions vortex-duckdb/src/exporter/fixed_size_list.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ pub(crate) fn new_exporter(
array: &FixedSizeListArray,
cache: &ConversionCache,
) -> VortexResult<Box<dyn ColumnExporter>> {
let elements_exporter = new_array_exporter(array.elements(), cache)?;
let elements_exporter = new_array_exporter(array.elements().to_canonical().as_ref(), cache)?;

Ok(Box::new(FixedSizeListExporter {
validity: array.validity_mask(),
Expand Down Expand Up @@ -69,13 +69,7 @@ impl ColumnExporter for FixedSizeListExporter {
self.elements_exporter
.export(offset * list_size, len * list_size, &mut elements_vector)?;

// TODO(connor): We must flatten the child vector to ensure any child dictionary views
// (namely UTF-8 string views in dictionaries) are materialized.
// See https://github.com/vortex-data/vortex/pull/4610#issuecomment-3286676825 for a
// detailed explanation on why we need this for now.
elements_vector.flatten((len * list_size) as u64);

Ok(())
Ok(())
}
}

Expand Down
Loading