Scancode: Fix false positive reported by scancode output analyser script #13745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@hugueskamba, thank you for your changes. |
hugueskamba
force-pushed
the
hk_evaluate_code_fix
branch
3 times, most recently
from
0e5a81a to
f3c54c2
Compare
rwalton-arm
previously requested changes
Oct 8, 2020
There was a problem hiding this comment.
What's the relationship between this PR and #13703? Is 13703 going to be closed?
hugueskamba
force-pushed
the
hk_evaluate_code_fix
branch
from
f3c54c2 to
584fa7a
Compare
mergify
bot
dismissed
rwalton-arm’s stale review
Pull request has been modified.
hugueskamba
force-pushed
the
hk_evaluate_code_fix
branch
3 times, most recently
from
e093429 to
9518d6a
Compare
harmut01
previously approved these changes
Oct 9, 2020
harmut01
reviewed
Oct 9, 2020
hugueskamba
force-pushed
the
hk_evaluate_code_fix
branch
from
9518d6a to
c28f4b1
Compare
hugueskamba
force-pushed
the
hk_evaluate_code_fix
branch
2 times, most recently
from
23b5a85 to
5306452
Compare
hugueskamba
force-pushed
the
hk_evaluate_code_fix
branch
from
5306452 to
58bfd93
Compare
0xc0170
approved these changes
Oct 16, 2020
|
We found 3 PRs affected by the bug that this PR is fixing (it should fix it). I would like to merge this asap to unblock other PRs for the upcoming release. @rwalton-arm would you review again? |
Jenkins CI Test : ❌ FAILEDBuild Number: 4 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
I restarted the client, not related |
rwalton-arm
approved these changes
Oct 16, 2020
|
CI restarted (pr-head was red, the rest was green) |
This was referenced Oct 16, 2020
Jenkins CI Test : ✔️ SUCCESSBuild Number: 5 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.4.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
ScanCodecan possibly return many licenses found for a single file scanned.This commit ensures that the file is not reported as lacking a permissive license
if at least one license found in it is permissive.
Previously the script was reporting an issue if it found at least one license
in a file that was not permissive.
Additionally catch more errors and provide specific details about failures.
Provide unit test.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers